Add note about CreateStatistics()'s selective use of check_rights.
authorNathan Bossart <[email protected]>
Fri, 14 Nov 2025 19:20:09 +0000 (13:20 -0600)
committerNathan Bossart <[email protected]>
Fri, 14 Nov 2025 19:20:09 +0000 (13:20 -0600)
commitd61af52ad1fcb86a6893c27e40aca492a57f35bc
treebcf5e0800725e3c8ba6c199bf9b650fe32468e43
parentc663152adcec438c72173e15021b94f54fa618fe
Add note about CreateStatistics()'s selective use of check_rights.

Commit 5e4fcbe531 added a check_rights parameter to this function
for use by ALTER TABLE commands that re-create statistics objects.
However, we intentionally ignore check_rights when verifying
relation ownership because this function's lookup could return a
different answer than the caller's.  This commit adds a note to
this effect so that we remember it down the road.

Reviewed-by: Noah Misch <[email protected]>
Backpatch-through: 14
src/backend/commands/statscmds.c