Remove XLogFileInit() ability to unlink a pre-existing file.
authorNoah Misch <[email protected]>
Tue, 29 Jun 2021 01:34:56 +0000 (18:34 -0700)
committerMichael Paquier <[email protected]>
Sun, 6 Apr 2025 05:48:01 +0000 (14:48 +0900)
commitd0b6acaf04a2eac17bf1533fb2991ab08da4a1be
tree31ead7292a31b33bcda8673b1fef424e4de3c21d
parent20e5ef3ca70c3dd42a015af5296d9164079542d4
Remove XLogFileInit() ability to unlink a pre-existing file.

Only initdb used it.  initdb refuses to operate on a non-empty directory
and generally does not cope with pre-existing files of other kinds.
Hence, use the opportunity to simplify.

This commit has been applied as of 421484f79c0b in v15 and newer
versions.  This is required on stable branches of v13 and v14 to fix a
regression reported by Noah Misch, introduced by 1f95181b44c8, causing
spurious failures in archive recovery (neither streaming nor archive
recovery) with concurrent restartpoints.  The backpatched versions of
the patches have been aligned on these branches by me, Noah Misch is the
author.  Tests have been conducted by the both of us.

Reported-by: Arun Thirupathi
Author: Noah Misch <[email protected]>
Discussion: https://postgr.es/m/20210202151416[email protected]
Discussion: https://postgr.es/m/20250306193013[email protected]
Backpatch-through: 13
src/backend/access/transam/xlog.c
src/backend/replication/walreceiver.c
src/include/access/xlog.h