Fix leakage of cost_limit when multiple autovacuum workers are active.
authorTom Lane <[email protected]>
Sat, 20 Nov 2010 03:28:25 +0000 (22:28 -0500)
committerTom Lane <[email protected]>
Sat, 20 Nov 2010 03:28:25 +0000 (22:28 -0500)
commitb5efc094042638154d74fdb1e8344ae0ba977617
treef35e1fb179c14e625cc8cd18a1587b57a139fa1c
parentb11accc9a9ade1b5da3ba0791b725dd29f9abeb7
Fix leakage of cost_limit when multiple autovacuum workers are active.

When using default autovacuum_vac_cost_limit, autovac_balance_cost relied
on VacuumCostLimit to contain the correct global value ... but after the
first time through in a particular worker process, it didn't, because we'd
trashed it in previous iterations.  Depending on the state of other autovac
workers, this could result in a steady reduction of the effective
cost_limit setting as a particular worker processed more and more tables,
causing it to go slower and slower.  Spotted by Simon Poole (bug #5759).
Fix by saving and restoring the GUC variables in the loop in do_autovacuum.

In passing, improve a few comments.

Back-patch to 8.3 ... the cost rebalancing code has been buggy since it was
put in.
src/backend/postmaster/autovacuum.c