Fix pg_dump to handle inherited NOT VALID check constraints correctly.
authorTom Lane <[email protected]>
Thu, 1 Oct 2015 20:19:49 +0000 (16:19 -0400)
committerTom Lane <[email protected]>
Thu, 1 Oct 2015 20:19:49 +0000 (16:19 -0400)
commit7e1e1c9d18c4d2d0b6cc64c697f6af043aac7f36
tree5fd21120fcd38799ebcd11fa658c52afd4502440
parentc3e847902fce46c44cd733506646bf19eaeecb6e
Fix pg_dump to handle inherited NOT VALID check constraints correctly.

This case seems to have been overlooked when unvalidated check constraints
were introduced, in 9.2.  The code would attempt to dump such constraints
over again for each child table, even though adding them to the parent
table is sufficient.

In 9.2 and 9.3, also fix contrib/pg_upgrade/Makefile so that the "make
clean" target fully cleans up after a failed test.  This evidently got
dealt with at some point in 9.4, but it wasn't back-patched.  I ran into
it while testing this fix ...

Per bug #13656 from Ingmar Brouns.
contrib/pg_upgrade/Makefile
src/bin/pg_dump/pg_dump.c
src/test/regress/expected/alter_table.out
src/test/regress/sql/alter_table.sql