Add indisreplident to fields refreshed by RelationReloadIndexInfo()
authorMichael Paquier <[email protected]>
Fri, 14 Jul 2023 02:16:11 +0000 (11:16 +0900)
committerMichael Paquier <[email protected]>
Fri, 14 Jul 2023 02:16:11 +0000 (11:16 +0900)
commit7d27493b74c5893fb50b82266d019964493318d9
tree4b32a512a2a730ecd702b4258344fcacffc33836
parentf1d6bcdd8fb5db1f71ea0e55ade2221c3c72c96e
Add indisreplident to fields refreshed by RelationReloadIndexInfo()

RelationReloadIndexInfo() is a fast-path used for index reloads in the
relation cache, and it has always forgotten about updating
indisreplident, which is something that would happen after an index is
selected for a replica identity.  This can lead to incorrect cache
information provided when executing a command in a transaction context
that updates indisreplident.

None of the code paths currently on HEAD that need to check upon
pg_index.indisreplident fetch its value from the relation cache, always
relying on a fresh copy on the syscache.  Unfortunately, this may not be
the case of out-of-core code, that could see out-of-date value.

Author: Shruthi Gowda
Reviewed-by: Robert Haas, Dilip Kumar, Michael Paquier
Discussion: https://postgr.es/m/CAASxf_PBcxax0wW-3gErUyftZ0XrCs3Lrpuhq4-Z3Fak1DoW7Q@mail.gmail.com
Backpatch-through: 11
src/backend/utils/cache/relcache.c