Ensure default-only storage parameters for TOAST relations
authorItagaki Takahiro <[email protected]>
Mon, 7 Jun 2010 03:01:35 +0000 (03:01 +0000)
committerItagaki Takahiro <[email protected]>
Mon, 7 Jun 2010 03:01:35 +0000 (03:01 +0000)
commit634b1614a05edc0cf2b70097818dba5a9314fc27
tree3e8f2ee6eafaf1ff47b96997820bb3bb646b09e2
parent32c6702f4d265dc7e25bec88c098f4a13f5cf7bf
Ensure default-only storage parameters for TOAST relations
to be initialized with proper values. Affected parameters are
fillfactor, analyze_threshold, and analyze_scale_factor.

Especially uninitialized fillfactor caused inefficient page usage
because we built a StdRdOptions struct in which fillfactor is zero
if any reloption is set for the toast table.

In addition, we disallow toast.autovacuum_analyze_threshold and
toast.autovacuum_analyze_scale_factor because we didn't actually
support them; they are always ignored.

Report by Rumko on pgsql-bugs on 12 May 2010.
Analysis by Tom Lane and Alvaro Herrera. Patch by me.

Backpatch to 8.4.
doc/src/sgml/ref/create_table.sgml
src/backend/access/common/reloptions.c