Fix a rare race condition when commit_siblings > 0 and a transaction commits
authorHeikki Linnakangas <[email protected]>
Tue, 31 Mar 2009 05:18:43 +0000 (05:18 +0000)
committerHeikki Linnakangas <[email protected]>
Tue, 31 Mar 2009 05:18:43 +0000 (05:18 +0000)
commit4ea51a3bd42c2d01c6f5cb7f2397538687c63539
tree2ab448588dc41bb496bb11525da50f51bd7faca5
parent2fa5db260818f3fc7cbfc457262afb2a8de2fd36
Fix a rare race condition when commit_siblings > 0 and a transaction commits
at the same instant as a new backend is spawned. Since CountActiveBackends()
doesn't hold ProcArrayLock, it needs to be prepared for the case that a
pointer at the end of the proc array is still NULL even though numProcs says
it should be valid, since it doesn't hold ProcArrayLock. Backpatch to 8.1.
8.0 and earlier had this right, but it was broken in the split of PGPROC and
sinval shared memory arrays.

Per report and proposal by Marko Kreen.
src/backend/storage/ipc/procarray.c