Remove overzealous _bt_killitems assertion.
authorPeter Geoghegan <[email protected]>
Fri, 10 Oct 2025 18:52:14 +0000 (14:52 -0400)
committerPeter Geoghegan <[email protected]>
Fri, 10 Oct 2025 18:52:14 +0000 (14:52 -0400)
commit314004021e549770d3d57fd0cf286050b948472d
treec55f5431aeeb051aebf61276841bbe7c59be1a1e
parentf57f2760e6651bb51bf99189e25a29ab4507860d
Remove overzealous _bt_killitems assertion.

An assertion in _bt_killitems expected the scan's currPos state to
contain a valid LSN, saved from when currPos's page was initially read.
The assertion failed to account for the fact that even logged relations
can have leaf pages with an invalid LSN when built with wal_level set to
"minimal".  Remove the faulty assertion.

Oversight in commit e6eed40e (though note that the assertion was
backpatched to stable branches before 18 by commit 7c319f54).

Author: Peter Geoghegan <[email protected]>
Reported-By: Matthijs van der Vleuten <[email protected]>
Bug: #19082
Discussion: https://postgr.es/m/19082-628e62160dbbc1c1@postgresql.org
Backpatch-through: 13
src/backend/access/nbtree/nbtutils.c