projects / users / c2main / postgres.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 7577975) | patch
stringToNode() and deparse_expression_pretty() crash on invalid input,
authorHeikki Linnakangas <[email protected]>
Wed, 30 Jun 2010 18:11:19 +0000 (18:11 +0000)
committerHeikki Linnakangas <[email protected]>
Wed, 30 Jun 2010 18:11:19 +0000 (18:11 +0000)
commit2c0080aaccdf4ca1d1832ef67c2b08447509a994
tree1f5fc56aaa137d96f0d945b94b0e030f2d25cc63tree
parent7577975515dd0a2896e3660eb55db0de0544106dcommit | diff
stringToNode() and deparse_expression_pretty() crash on invalid input,
but we have nevertheless exposed them to users via pg_get_expr(). It would
be too much maintenance effort to rigorously check the input, so put a hack
in place instead to restrict pg_get_expr() so that the argument must come
from one of the system catalog columns known to contain valid expressions.

Per report from Rushabh Lathia. Backpatch to 7.4 which is the oldest
supported version at the moment.
src/backend/parser/parse_expr.c diff | blob | blame | history
src/backend/tcop/fastpath.c diff | blob | blame | history
src/include/catalog/pg_constraint.h diff | blob | blame | history
Cedric's Stuff