Remove unnecessary Windows-specific basebackup code.
authorThomas Munro <[email protected]>
Fri, 22 Jul 2022 05:37:39 +0000 (17:37 +1200)
committerThomas Munro <[email protected]>
Fri, 22 Jul 2022 05:42:22 +0000 (17:42 +1200)
commit202b56ba91cb6c0741cc9340ac57a50dbcdac549
tree300bf0458efba6538b060a0cd8785b61c6f1efe1
parent6d306ab731689ca01cdcafda9862732dcc075778
Remove unnecessary Windows-specific basebackup code.

Commit c6f2f016 added an explicit check for a Windows "junction point".
That turned out to be needed only because get_dirent_type() was busted
on Windows.  It's been fixed by commit 9d3444dc, so remove it.

Add a TAP-test to demonstrate that in-place tablespaces are copied by
pg_basebackup.  This exercises the codepath that would fail before
c6f2f016 on Windows, and shows that it still doesn't fail now that we're
using get_dirent_type() on both Windows and Unix.

Back-patch to 15, where in-place tablespaces arrived and caused this
problem (ie directories where previously only symlinks were expected).

Reviewed-by: Michael Paquier <[email protected]>
Discussion: https://postgr.es/m/CA%2BhUKGLzLK4PUPx0_AwXEWXOYAejU%3D7XpxnYE55Y%2Be7hB2N3FA%40mail.gmail.com
src/backend/access/transam/xlog.c
src/bin/pg_basebackup/t/010_pg_basebackup.pl