Use snprintf not sprintf in pg_waldump's timestamptz_to_str.
authorTom Lane <[email protected]>
Sat, 16 Jun 2018 18:45:47 +0000 (14:45 -0400)
committerTom Lane <[email protected]>
Sat, 16 Jun 2018 18:45:47 +0000 (14:45 -0400)
commit18933261589c9547d5c517cdc05f25362cce412a
treec7704ec42cbf17d8c8ab979090c462998fd7a4b4
parent3b5f4f1f40b241d08ed36df1716e07a6b0560e5c
Use snprintf not sprintf in pg_waldump's timestamptz_to_str.

This could only cause an issue if strftime returned a ridiculously
long timezone name, which seems unlikely; and it wouldn't qualify
as a security problem even then, since pg_waldump (nee pg_xlogdump)
is a debug tool not part of the server.  But gcc 8 has started issuing
warnings about it, so let's use snprintf and be safe.

Backpatch to 9.3 where this code was added.

Discussion: https://postgr.es/m/21789.1529170195@sss.pgh.pa.us
src/bin/pg_waldump/compat.c