libpqwalreceiver needs to link with libintl when using --enable-nls.
authorTom Lane <[email protected]>
Sat, 8 Oct 2016 01:12:25 +0000 (21:12 -0400)
committerTom Lane <[email protected]>
Sat, 8 Oct 2016 01:12:25 +0000 (21:12 -0400)
commit008a7dc327ba3165e7fab17d4cbb58c0f2ded3a5
tree1ab6e62576da972cdb1b626d41cc06af7b62ce76
parent93fd6de14156d8d9c8d47e6cbfd067ab2b02e399
libpqwalreceiver needs to link with libintl when using --enable-nls.

The need for this was previously obscured even on picky platforms
by the hack we used to support direct cross-module references in
the transforms contrib modules.  Now that that hack is gone, the
undefined symbol is exposed, as reported by Robert Haas.

Back-patch to 9.5 where we started to use -Wl,-undefined,dynamic_lookup.
I'm a bit surprised that the older branches don't seem to contain
any gettext references in this module, but since they don't fail
at build time, they must not.  (We might be able to get away with
leaving this alone in 9.5/9.6, but I think it's cleaner if the
reference gets resolved at link time.)

Report: <CA+TgmoaHJKU5kcWZcYduATYVT7Mnx+8jUnycaYYL7OtCwCigug@mail.gmail.com>
src/backend/replication/libpqwalreceiver/Makefile