Update comments to reflect changes in 8e0d32a4a1.

Commit 8e0d32a4a1 fixed an issue by allowing the replication origin to be
created while marking the table sync state as SUBREL_STATE_DATASYNC.
Update the comment in check_old_cluster_subscription_state() to accurately
describe this corrected behavior.

Author: Amit Kapila <[email protected]>
Reviewed-by: Michael Paquier <[email protected]>
Backpatch-through: 17, where the code was introduced
Discussion: https://postgr.es/m/CAA4eK1+KaSf5nV_tWy+SDGV6MnFnKMhdt41jJjSDWm6yCyOcTw@mail.gmail.com
Discussion: https://postgr.es/m/[email protected]

diff --git a/src/bin/pg_upgrade/check.c b/src/bin/pg_upgrade/check.c
index 9cdeb15bd51f67bbcb82a7121ac1d63097fc8a8c..c77ebeff88371ba63bbe9dd2a0817647f44eeecc 100644 (file)
--- a/src/bin/pg_upgrade/check.c
+++ b/src/bin/pg_upgrade/check.c
@@ -2383,9 +2383,9 @@ check_old_cluster_subscription_state(void)
     * states listed below are not supported:
     *
     * a) SUBREL_STATE_DATASYNC: A relation upgraded while in this state would
-    * retain a replication slot, which could not be dropped by the sync
-    * worker spawned after the upgrade because the subscription ID used for
-    * the slot name won't match anymore.
+    * retain a replication slot and origin. The sync worker spawned after the
+    * upgrade cannot drop them because the subscription ID used for the slot
+    * and origin name no longer matches.
     *
     * b) SUBREL_STATE_SYNCDONE: A relation upgraded while in this state would
     * retain the replication origin when there is a failure in tablesync