Clean up test_cloexec.c and Makefile. REL_16_STABLE github/REL_16_STABLE
authorThomas Munro <[email protected]>
Sun, 21 Dec 2025 02:40:07 +0000 (15:40 +1300)
committerThomas Munro <[email protected]>
Sun, 21 Dec 2025 04:36:04 +0000 (17:36 +1300)
commit0666ccc16cc2d1b97032e7723601dbf5300d057d
treecf6e2111e2adc32460e07b80ff550dcb610dfee8
parent3853f61681e850e846150b38cf9f5ebb34523740
Clean up test_cloexec.c and Makefile.

An unused variable caused a compiler warning on BF animal fairywren, an
snprintf() call was redundant, and some buffer sizes were inconsistent.
Per code review from Tom Lane.

The Makefile's test ifeq ($(PORTNAME), win32) never succeeded due to a
circularity, so only Meson builds were actually compiling the new test
code, partially explaining why CI didn't tell us about the warning
sooner (the other problem being that CompilerWarnings only makes
world-bin, a problem for another commit).  Simplify.

Backpatch-through: 16, like commit c507ba55
Author: Bryan Green <[email protected]>
Co-authored-by: Thomas Munro <[email protected]>
Reported-by: Tom Lane <[email protected]>
Discussion: https://postgr.es/m/1086088.1765593851%40sss.pgh.pa.us
src/test/modules/test_cloexec/Makefile
src/test/modules/test_cloexec/test_cloexec.c