Fix catcache invalidation of a list entry that's being built
authorHeikki Linnakangas <[email protected]>
Tue, 14 Jan 2025 16:54:56 +0000 (18:54 +0200)
committerHeikki Linnakangas <[email protected]>
Tue, 14 Jan 2025 16:54:56 +0000 (18:54 +0200)
commitf217c410553d28ca182952465d848331945959a4
tree1aabf4ea870c15edc5dab0d390d780b825aa1868
parent226c9048d734ba13ef88c04a7405a67ad8014a7d
Fix catcache invalidation of a list entry that's being built

If a new catalog tuple is inserted that belongs to a catcache list
entry, and cache invalidation happens while the list entry is being
built, the list entry might miss the newly inserted tuple.

To fix, change the way we detect concurrent invalidations while a
catcache entry is being built. Keep a stack of entries that are being
built, and apply cache invalidation to those entries in addition to
the real catcache entries. This is similar to the in-progress list in
relcache.c.

Back-patch to all supported versions. (This commit to v13 a few hours
later than other branches, because I somehow missed v13 in the first
batch.)

Reviewed-by: Noah Misch
Discussion: https://www.postgresql.org/message-id/2234dc98-06fe-42ed-b5db-ac17384dc880@iki.fi
src/backend/utils/cache/catcache.c
src/backend/utils/cache/inval.c
src/include/utils/catcache.h
src/tools/pgindent/typedefs.list