gen_guc_tables.pl: Validate required GUC fields before code generation
authorPeter Eisentraut <[email protected]>
Tue, 25 Nov 2025 15:50:34 +0000 (16:50 +0100)
committerPeter Eisentraut <[email protected]>
Tue, 25 Nov 2025 15:50:34 +0000 (16:50 +0100)
commit7169c0b96bb8929c939c8e96a52b42571085efe9
treea8e573cd739f9d8f7d2e4f4854ace8b3adff7825
parent2256af4ba223e114d08208fd17a27cbce30cda9e
gen_guc_tables.pl: Validate required GUC fields before code generation

Previously, gen_guc_tables.pl would emit "Use of uninitialized value"
warnings if required fields were missing in guc_parameters.dat (for
example, when an integer or real GUC omitted the 'max' value).  The
resulting error messages were unclear and did not identify which GUC
entry was problematic.

Add explicit validation of required fields depending on the parameter
type, and fail with a clear and specific message such as:

    guc_parameters.dat:1909: error: entry "max_index_keys" of type "int" is missing required field "max"

No changes to generated guc_tables.c.

Author: Chao Li <[email protected]>
Reviewed-by: Dagfinn Ilmari MannsÃ¥ker <[email protected]>
Reviewed-by: Peter Eisentraut <[email protected]>
Discussion: https://www.postgresql.org/message-id/flat/CAEoWx2%3DoP4LgHi771_OKhPPUS7B-CTqCs%3D%3DuQcNXWrwBoAm5Vg%40mail.gmail.com
src/backend/utils/misc/gen_guc_tables.pl