Do not emit WAL for unlogged BRIN indexes master github/master
authorHeikki Linnakangas <[email protected]>
Thu, 18 Dec 2025 13:08:48 +0000 (15:08 +0200)
committerHeikki Linnakangas <[email protected]>
Thu, 18 Dec 2025 13:08:48 +0000 (15:08 +0200)
commit951b60f7abdcdeb37f2d73ad4822f278d2687c1c
tree028732aab31ee74a24643711f602030f8efdb463
parentb47c50e5667b489bec3affb55ecdf4e9c306ca2d
Do not emit WAL for unlogged BRIN indexes

Operations on unlogged relations should not be WAL-logged. The
brin_initialize_empty_new_buffer() function didn't get the memo.

The function is only called when a concurrent update to a brin page
uses up space that we're just about to insert to, which makes it
pretty hard to hit. If you do manage to hit it, a full-page WAL record
is erroneously emitted for the unlogged index. If you then crash,
crash recovery will fail on that record with an error like this:

    FATAL:  could not create file "base/5/32819": File exists

Author: Kirill Reshke <[email protected]>
Discussion: https://www.postgresql.org/message-id/CALdSSPhpZXVFnWjwEBNcySx_vXtXHwB2g99gE6rK0uRJm-3GgQ@mail.gmail.com
Backpatch-through: 14
src/backend/access/brin/brin_pageops.c