From 39d7f03ca113580a291fe45e221565d9b97396ff Mon Sep 17 00:00:00 2001 From: Tomas Vondra Date: Thu, 4 May 2017 19:41:53 +0200 Subject: [PATCH] Resolve failures in without_oid test suite by switching to CTAS The tests used CREATE TABLE ... AS EXECUTE to populate two of the tables, but this is unsupported in Postgres-XL and so resulted in test failures. Instead switch to CREATE TABLE ... AS SELECT. --- src/test/regress/expected/without_oid.out | 6 ++---- src/test/regress/sql/without_oid.sql | 7 ++----- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/src/test/regress/expected/without_oid.out b/src/test/regress/expected/without_oid.out index cb2c0c0137..ec159c8fdf 100644 --- a/src/test/regress/expected/without_oid.out +++ b/src/test/regress/expected/without_oid.out @@ -81,10 +81,8 @@ SELECT count(oid) FROM create_table_test3; ERROR: column "oid" does not exist LINE 1: SELECT count(oid) FROM create_table_test3; ^ -PREPARE table_source(int) AS - SELECT a + b AS c1, a - b AS c2, $1 AS c3 FROM create_table_test; -CREATE TABLE execute_with WITH OIDS AS EXECUTE table_source(1); -CREATE TABLE execute_without WITHOUT OIDS AS EXECUTE table_source(2); +CREATE TABLE execute_with WITH OIDS AS SELECT a + b AS c1, a - b AS c2, 1 AS c3 FROM create_table_test; +CREATE TABLE execute_without WITHOUT OIDS AS SELECT a + b AS c1, a - b AS c2, 2 AS c3 FROM create_table_test; SELECT count(oid) FROM execute_with; count ------- diff --git a/src/test/regress/sql/without_oid.sql b/src/test/regress/sql/without_oid.sql index 9fbb454d4d..2176add7fe 100644 --- a/src/test/regress/sql/without_oid.sql +++ b/src/test/regress/sql/without_oid.sql @@ -75,11 +75,8 @@ SELECT count(oid) FROM create_table_test2; -- should fail SELECT count(oid) FROM create_table_test3; -PREPARE table_source(int) AS - SELECT a + b AS c1, a - b AS c2, $1 AS c3 FROM create_table_test; - -CREATE TABLE execute_with WITH OIDS AS EXECUTE table_source(1); -CREATE TABLE execute_without WITHOUT OIDS AS EXECUTE table_source(2); +CREATE TABLE execute_with WITH OIDS AS SELECT a + b AS c1, a - b AS c2, 1 AS c3 FROM create_table_test; +CREATE TABLE execute_without WITHOUT OIDS AS SELECT a + b AS c1, a - b AS c2, 2 AS c3 FROM create_table_test; SELECT count(oid) FROM execute_with; -- should fail -- 2.39.5