From: Heikki Linnakangas Date: Fri, 19 Dec 2025 11:40:02 +0000 (+0200) Subject: Use proper type for RestoreTransactionSnapshot's PGPROC arg X-Git-Url: http://git.postgresql.org/gitweb/irc:/static/gitweb.js?a=commitdiff_plain;h=47a9f61fcafcf26bd3d68740ca05ba69ac729d93;p=postgresql.git Use proper type for RestoreTransactionSnapshot's PGPROC arg Reviewed-by: Chao Li Discussion: https://www.postgresql.org/message-id/08cbaeb5-aaaf-47b6-9ed8-4f7455b0bc4b@iki.fi --- diff --git a/src/backend/utils/time/snapmgr.c b/src/backend/utils/time/snapmgr.c index 40a2e90e071..5af8326d5e8 100644 --- a/src/backend/utils/time/snapmgr.c +++ b/src/backend/utils/time/snapmgr.c @@ -1848,12 +1848,9 @@ RestoreSnapshot(char *start_address) /* * Install a restored snapshot as the transaction snapshot. - * - * The second argument is of type void * so that snapmgr.h need not include - * the declaration for PGPROC. */ void -RestoreTransactionSnapshot(Snapshot snapshot, void *source_pgproc) +RestoreTransactionSnapshot(Snapshot snapshot, PGPROC *source_pgproc) { SetTransactionSnapshot(snapshot, NULL, InvalidPid, source_pgproc); } diff --git a/src/include/utils/snapmgr.h b/src/include/utils/snapmgr.h index 604c1f90216..b663d3bbc8c 100644 --- a/src/include/utils/snapmgr.h +++ b/src/include/utils/snapmgr.h @@ -120,6 +120,7 @@ extern bool HistoricSnapshotActive(void); extern Size EstimateSnapshotSpace(Snapshot snapshot); extern void SerializeSnapshot(Snapshot snapshot, char *start_address); extern Snapshot RestoreSnapshot(char *start_address); -extern void RestoreTransactionSnapshot(Snapshot snapshot, void *source_pgproc); +struct PGPROC; +extern void RestoreTransactionSnapshot(Snapshot snapshot, struct PGPROC *source_pgproc); #endif /* SNAPMGR_H */