From 27bc3ceb418c1d6bb83c21e5fffb4f03b27b1f8e Mon Sep 17 00:00:00 2001 From: Tatsuo Ishii Date: Wed, 24 Dec 2025 15:46:54 +0900 Subject: [PATCH] Fix duplicate NodeTag enum in nodes.h. The file was imported from PostgreSQL and Pgpool-II specific node type were added right after T_Invalid = 0, then nodetags.h is included. Since nodetags.h explicitly assign values to each enum starting from 1, and this created duplicated enums. T_List = 1, T_Alias = 2, T_RangeVar = 3, T_PgpoolVariableSetStmt, (1) T_PgpoolVariableShowStmt, (2) T_PgpoolQueryCacheStmt, (3) Although fortunately this seems does not create any trouble except the duplicated enums, this should be fixed: moving the inclusion of nodetags.h right after "T_invalid = 0". Reported-by: liujinyang-highgo Diagnosed-by: liujinyang-highgo Discussion: https://github.com/pgpool/pgpool2/issues/138 Backpatch-through: v4.5 --- src/include/parser/nodes.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/include/parser/nodes.h b/src/include/parser/nodes.h index 275694786..5412ef4c8 100644 --- a/src/include/parser/nodes.h +++ b/src/include/parser/nodes.h @@ -30,12 +30,11 @@ typedef enum NodeTag { T_Invalid = 0, - +#include "nodetags.h" /* pgpool Extension */ T_PgpoolVariableSetStmt, T_PgpoolVariableShowStmt, T_PgpoolQueryCacheStmt, -#include "nodetags.h" } NodeTag; /* -- 2.39.5