From: Tatsuo Ishii <ishii@postgresql.org>
Date: Wed, 24 Dec 2025 06:46:54 +0000 (+0900)
Subject: Fix duplicate NodeTag enum in nodes.h.
X-Git-Url: http://git.postgresql.org/gitweb/irc:/sta%3Cscript%20data-cfasync=?a=commitdiff_plain;h=HEAD;p=pgpool2.git

Fix duplicate NodeTag enum in nodes.h.

The file was imported from PostgreSQL and Pgpool-II specific node type
were added right after T_Invalid = 0, then nodetags.h is
included. Since nodetags.h explicitly assign values to each enum
starting from 1, and this created duplicated enums.
T_List = 1,
T_Alias = 2,
T_RangeVar = 3,
T_PgpoolVariableSetStmt, (1)
T_PgpoolVariableShowStmt, (2)
T_PgpoolQueryCacheStmt, (3)

Although fortunately this seems does not create any trouble except the
duplicated enums, this should be fixed: moving the inclusion of
nodetags.h right after "T_invalid = 0".

Reported-by: liujinyang-highgo
Diagnosed-by: liujinyang-highgo
Discussion: https://github.com/pgpool/pgpool2/issues/138
Backpatch-through: v4.5
---

diff --git a/src/include/parser/nodes.h b/src/include/parser/nodes.h
index 275694786..5412ef4c8 100644
--- a/src/include/parser/nodes.h
+++ b/src/include/parser/nodes.h
@@ -30,12 +30,11 @@
 typedef enum NodeTag
 {
 	T_Invalid = 0,
-
+#include "nodetags.h"
 	/* pgpool Extension */
 	T_PgpoolVariableSetStmt,
 	T_PgpoolVariableShowStmt,
 	T_PgpoolQueryCacheStmt,
-#include "nodetags.h"
 } NodeTag;
 
 /*