Don't allow CTEs to determine semantic levels of aggregates.

The fix for bug #19055 (commit b0cc0a71e) allowed CTE references in
sub-selects within aggregate functions to affect the semantic levels
assigned to such aggregates.  It turns out this broke some related
cases, leading to assertion failures or strange planner errors such
as "unexpected outer reference in CTE query".  After experimenting
with some alternative rules for assigning the semantic level in
such cases, we've come to the conclusion that changing the level
is more likely to break things than be helpful.

Therefore, this patch undoes what b0cc0a71e changed, and instead
installs logic to throw an error if there is any reference to a
CTE that's below the semantic level that standard SQL rules would
assign to the aggregate based on its contained Var and Aggref nodes.
(The SQL standard disallows sub-selects within aggregate functions,
so it can't reach the troublesome case and hence has no rule for
what to do.)

Perhaps someone will come along with a legitimate query that this
logic rejects, and if so probably the example will help us craft
a level-adjustment rule that works better than what b0cc0a71e did.
I'm not holding my breath for that though, because the previous
logic had been there for a very long time before bug #19055 without
complaints, and that bug report sure looks to have originated from
fuzzing not from real usage.

Like b0cc0a71e, back-patch to all supported branches, though
sadly that no longer includes v13.

Bug: #19106
Reported-by: Kamil Monicz <[email protected]>
Author: Tom Lane <[email protected]>
Discussion: https://postgr.es/m/19106-9dd3668a0734cd72@postgresql.org
Backpatch-through: 14

diff --git a/src/backend/parser/parse_agg.c b/src/backend/parser/parse_agg.c
index 9b72bb2a67fb5484f14754a60dfa8406723c9717..f9f066ed129d8164f8453923ec61db5fd2dea979 100644 (file)
--- a/src/backend/parser/parse_agg.c
+++ b/src/backend/parser/parse_agg.c
@@ -36,6 +36,8 @@ typedef struct
    ParseState *pstate;
    int         min_varlevel;
    int         min_agglevel;
+   int         min_ctelevel;
+   RangeTblEntry *min_cte;
    int         sublevels_up;
 } check_agg_arguments_context;
 
@@ -55,7 +57,8 @@ typedef struct
 static int check_agg_arguments(ParseState *pstate,
                                List *directargs,
                                List *args,
-                               Expr *filter);
+                               Expr *filter,
+                               int agglocation);
 static bool check_agg_arguments_walker(Node *node,
                                       check_agg_arguments_context *context);
 static void check_ungrouped_columns(Node *node, ParseState *pstate, Query *qry,
@@ -333,7 +336,8 @@ check_agglevels_and_constraints(ParseState *pstate, Node *expr)
    min_varlevel = check_agg_arguments(pstate,
                                       directargs,
                                       args,
-                                      filter);
+                                      filter,
+                                      location);
 
    *p_levelsup = min_varlevel;
 
@@ -634,7 +638,8 @@ static int
 check_agg_arguments(ParseState *pstate,
                    List *directargs,
                    List *args,
-                   Expr *filter)
+                   Expr *filter,
+                   int agglocation)
 {
    int         agglevel;
    check_agg_arguments_context context;
@@ -642,6 +647,8 @@ check_agg_arguments(ParseState *pstate,
    context.pstate = pstate;
    context.min_varlevel = -1;  /* signifies nothing found yet */
    context.min_agglevel = -1;
+   context.min_ctelevel = -1;
+   context.min_cte = NULL;
    context.sublevels_up = 0;
 
    (void) check_agg_arguments_walker((Node *) args, &context);
@@ -679,6 +686,20 @@ check_agg_arguments(ParseState *pstate,
                 parser_errposition(pstate, aggloc)));
    }
 
+   /*
+    * If there's a non-local CTE that's below the aggregate's semantic level,
+    * complain.  It's not quite clear what we should do to fix up such a case
+    * (treating the CTE reference like a Var seems wrong), and it's also
+    * unclear whether there is a real-world use for such cases.
+    */
+   if (context.min_ctelevel >= 0 && context.min_ctelevel < agglevel)
+       ereport(ERROR,
+               (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
+                errmsg("outer-level aggregate cannot use a nested CTE"),
+                errdetail("CTE \"%s\" is below the aggregate's semantic level.",
+                          context.min_cte->eref->aliasname),
+                parser_errposition(pstate, agglocation)));
+
    /*
     * Now check for vars/aggs in the direct arguments, and throw error if
     * needed.  Note that we allow a Var of the agg's semantic level, but not
@@ -692,6 +713,7 @@ check_agg_arguments(ParseState *pstate,
    {
        context.min_varlevel = -1;
        context.min_agglevel = -1;
+       context.min_ctelevel = -1;
        (void) check_agg_arguments_walker((Node *) directargs, &context);
        if (context.min_varlevel >= 0 && context.min_varlevel < agglevel)
            ereport(ERROR,
@@ -707,6 +729,13 @@ check_agg_arguments(ParseState *pstate,
                     parser_errposition(pstate,
                                        locate_agg_of_level((Node *) directargs,
                                                            context.min_agglevel))));
+       if (context.min_ctelevel >= 0 && context.min_ctelevel < agglevel)
+           ereport(ERROR,
+                   (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
+                    errmsg("outer-level aggregate cannot use a nested CTE"),
+                    errdetail("CTE \"%s\" is below the aggregate's semantic level.",
+                              context.min_cte->eref->aliasname),
+                    parser_errposition(pstate, agglocation)));
    }
    return agglevel;
 }
@@ -787,11 +816,6 @@ check_agg_arguments_walker(Node *node,
 
    if (IsA(node, RangeTblEntry))
    {
-       /*
-        * CTE references act similarly to Vars of the CTE's level.  Without
-        * this we might conclude that the Agg can be evaluated above the CTE,
-        * leading to trouble.
-        */
        RangeTblEntry *rte = (RangeTblEntry *) node;
 
        if (rte->rtekind == RTE_CTE)
@@ -803,9 +827,12 @@ check_agg_arguments_walker(Node *node,
            /* ignore local CTEs of subqueries */
            if (ctelevelsup >= 0)
            {
-               if (context->min_varlevel < 0 ||
-                   context->min_varlevel > ctelevelsup)
-                   context->min_varlevel = ctelevelsup;
+               if (context->min_ctelevel < 0 ||
+                   context->min_ctelevel > ctelevelsup)
+               {
+                   context->min_ctelevel = ctelevelsup;
+                   context->min_cte = rte;
+               }
            }
        }
        return false;           /* allow range_table_walker to continue */

diff --git a/src/test/regress/expected/with.out b/src/test/regress/expected/with.out
index bd08d80b2587b7ae2e4cf62a1adaed38d83cdd66..9262e82b2757e68fc6d790544b3b21341b091d47 100644 (file)
--- a/src/test/regress/expected/with.out
+++ b/src/test/regress/expected/with.out
@@ -2226,36 +2226,44 @@ from int4_tbl;
 --
 -- test for bug #19055: interaction of WITH with aggregates
 --
--- The reference to cte1 must determine the aggregate's level,
--- even though it contains no Vars referencing cte1
-explain (verbose, costs off)
+-- For now, we just throw an error if there's a use of a CTE below the
+-- semantic level that the SQL standard assigns to the aggregate.
+-- It's not entirely clear what we could do instead that doesn't risk
+-- breaking more things than it fixes.
 select f1, (with cte1(x,y) as (select 1,2)
             select count((select i4.f1 from cte1))) as ss
 from int4_tbl i4;
-            QUERY PLAN             
------------------------------------
- Seq Scan on public.int4_tbl i4
-   Output: i4.f1, (SubPlan 2)
-   SubPlan 2
+ERROR:  outer-level aggregate cannot use a nested CTE
+LINE 2:             select count((select i4.f1 from cte1))) as ss
+                           ^
+DETAIL:  CTE "cte1" is below the aggregate's semantic level.
+--
+-- test for bug #19106: interaction of WITH with aggregates
+--
+-- the initial fix for #19055 was too aggressive and broke this case
+explain (verbose, costs off)
+with a as ( select id from (values (1), (2)) as v(id) ),
+     b as ( select max((select sum(id) from a)) as agg )
+select agg from b;
+                 QUERY PLAN                 
+--------------------------------------------
+ Aggregate
+   Output: max($0)
+   InitPlan 1 (returns $0)
      ->  Aggregate
-           Output: count($1)
-           InitPlan 1 (returns $1)
-             ->  Result
-                   Output: i4.f1
-           ->  Result
-(9 rows)
-
-select f1, (with cte1(x,y) as (select 1,2)
-            select count((select i4.f1 from cte1))) as ss
-from int4_tbl i4;
-     f1      | ss 
--------------+----
-           0 |  1
-      123456 |  1
-     -123456 |  1
-  2147483647 |  1
- -2147483647 |  1
-(5 rows)
+           Output: sum("*VALUES*".column1)
+           ->  Values Scan on "*VALUES*"
+                 Output: "*VALUES*".column1
+   ->  Result
+(8 rows)
+
+with a as ( select id from (values (1), (2)) as v(id) ),
+     b as ( select max((select sum(id) from a)) as agg )
+select agg from b;
+ agg 
+-----
+   3
+(1 row)
 
 --
 -- test for nested-recursive-WITH bug

diff --git a/src/test/regress/sql/with.sql b/src/test/regress/sql/with.sql
index 64f4bd642ec02dced79d2767ea696d9d1819eb8d..56b474cf5ec053d43a87ef94bf67d2741e11a5a5 100644 (file)
--- a/src/test/regress/sql/with.sql
+++ b/src/test/regress/sql/with.sql
@@ -1067,16 +1067,26 @@ from int4_tbl;
 --
 -- test for bug #19055: interaction of WITH with aggregates
 --
--- The reference to cte1 must determine the aggregate's level,
--- even though it contains no Vars referencing cte1
-explain (verbose, costs off)
+-- For now, we just throw an error if there's a use of a CTE below the
+-- semantic level that the SQL standard assigns to the aggregate.
+-- It's not entirely clear what we could do instead that doesn't risk
+-- breaking more things than it fixes.
 select f1, (with cte1(x,y) as (select 1,2)
             select count((select i4.f1 from cte1))) as ss
 from int4_tbl i4;
 
-select f1, (with cte1(x,y) as (select 1,2)
-            select count((select i4.f1 from cte1))) as ss
-from int4_tbl i4;
+--
+-- test for bug #19106: interaction of WITH with aggregates
+--
+-- the initial fix for #19055 was too aggressive and broke this case
+explain (verbose, costs off)
+with a as ( select id from (values (1), (2)) as v(id) ),
+     b as ( select max((select sum(id) from a)) as agg )
+select agg from b;
+
+with a as ( select id from (values (1), (2)) as v(id) ),
+     b as ( select max((select sum(id) from a)) as agg )
+select agg from b;
 
 --
 -- test for nested-recursive-WITH bug