Wikipedia:Bots/Requests for approval/MajavahBot

MajavahBot

• (BRFA
• Approved BRFAs
• talk
• contribs
• count
• SUL
• logs
• page moves
• block log
• rights log
• flag)

Operator: Majavah (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)

Time filed: 09:02, Saturday, November 23, 2019 (UTC)

Automatic, Supervised, or Manual: automatic

Programming language(s): Python

Source code available: https://github.com/supertassu/majavahbot

Function overview: This bot will patrol WP:EFFPR and automatically 1) add messages such as "User blocked" and "Private filter" from {{effp}}, 2) add or fix typos or formatting in filter title in reports and 3) archive old reports.

Links to relevant discussions (where appropriate): Wikipedia:Edit filter/Noticeboard#Bot idea for EFFP

Edit period(s): Continuous

Estimated number of pages affected: WP:EFFPR + archive page

Exclusion compliant (Yes/No): Yes

Already has a bot flag (Yes/No): No

Function details: Using wikitech:EventStreams, the bot will listen to changes on the false positive page, and automatically clerks the reports. Some checks (filter private, task name) are only ran when a new report is added and some (archive, user blocked) are ran after every edit to the page.

About the archiving function: Similar to RFPP, the bot will maintain a rolling archive of 25 (configurable) last reports on a separate page. All reports older will be hidden in page histories. Reports will be archived based on when the last comment was posted, and comments posted on the report can be used to change the delay (for example, if {{effp|denied}} template is used, the report will be archived in 1h after the reply instead of 48h which is used as a default).

Discussion

I see that that noticeboard is currently archived by Lowercase sigmabot III. I am a little unsure what add or fix typos or formatting in filter title in reports means; can you clarify? Jo-Jo Eumerus (talk) 13:25, 23 November 2019 (UTC)

@Jo-Jo Eumerus: The noticeboard is currently archived by Sigmabot, however it isn't very great at the reports page (more reasoning in discussion linked above). The fixing filter title in reports means that if the user creating a report there either does not fill in title of the affected page at all or if there's an obvious mistake (capitalization in later chars or directly pasting in page URL instead of name) in the report, the bot will correct that. Regards, Majavah ^(t/c) 14:03, 23 November 2019 (UTC) (typo fixed at 21:09, 23 November 2019 (UTC))

{{BAG assistance needed}} I'm requesting BAG assistance as it's been over a week since the last reply. Majavah ^(t/c) 08:06, 3 December 2019 (UTC)

Approved for trial (7 days). Please provide a link to the relevant contributions and/or diffs when the trial is complete. For this trial, have the bot make edits to a subpage in its user space; archives should go to another subpage. This way we can tell if the bot works without potentially messing with the main EFFPR page. Code looks good to me; interesting strategy to make a Pywikibot wrapper. The field self.open in database.py looks a bit suspicious to me, but it'll probably be fine. Thank you for writing this bot! Enterprisey (talk!) 18:17, 3 December 2019 (UTC)

Great, I'll start the trial at tomorrow as I'm having some issues with Toolforge's job engine (most likely user error). And yes, self.open in database.py is really hacky, however it works(TM) and it does not keep a database connection open when not necessary to comply with replica database guidelines on wikitech. --Majavah ^(t/c) 19:12, 3 December 2019 (UTC)

Majavah, good to hear. And one more thing: the boy's configuration page, being currently semi-protected, is of course editable by any autoconfirmed user. That's not ideal, so it should be moved to a JSON contentmodel (ie the page title should end in .json) so that only the bot account (and interface admins) can edit it. Enterprisey (talk!) 00:32, 4 December 2019 (UTC)

@Enterprisey: Note: any admin can edit user json pages. Also, moving it to a .json page wouldn't change the content model; it would need to be recreated DannyS712 (talk) 01:45, 4 December 2019 (UTC)

I've corrected my comment (thanks for pointing that out), and yeah, I'll change the content model when it gets moved. Enterprisey (talk!) 02:14, 4 December 2019 (UTC)

@Enterprisey: which would mean that the bot op cannot edit the config - maybe ecp protection? DannyS712 (talk) 02:23, 4 December 2019 (UTC)

The bot op could still log in using the bot account. Alternatively, and this is probably a better idea, the bot op could put it in their own userspace. Enterprisey (talk!) 02:27, 4 December 2019 (UTC)

@Enterprisey and DannyS712: This was discussed on the edit filter noticeboard (Wikipedia:Edit_filter_noticeboard#Bot_idea_for_EFFP), and it was agreed that it should be possible for at least edit filter managers to adjust the config without bugging me. Majavah ^(t/c) 07:07, 4 December 2019 (UTC)

Also, I've started the trial, and on the database it's marked to end at 2019-12-11 07:27:28 UTC. Majavah ^(t/c) 07:53, 4 December 2019 (UTC)

Trial complete. I fixed a few edge cases in the beginning. Majavah ^(t/c) 17:59, 11 December 2019 (UTC)

Will get to reading through the contribs in the next few days; sorry for the delay. Enterprisey (talk!) 06:47, 19 December 2019 (UTC)