kiesel-js/kiesel
kiesel-js/kiesel
Watch
11
317
Fork
You've already forked kiesel
 24
Code Issues 28 Pull requests 1 Releases 2 Activity Actions

[Tracking issue] Temporal implementation progress #124

New issue
Closed
opened 2025-06-19 16:07:50 +02:00 by linus · 3 comments
linus commented 2025-06-19 16:07:50 +02:00
Owner
Copy link

Implementation is complete, we only have to keep in sync with editorial and normative changes now.

(only started tracking in November 2025 but earlier changes should be implemented)

Implementation is complete, we only have to keep in sync with editorial and normative changes now. (only started tracking in November 2025 but earlier changes _should_ be implemented) - [x] ~~[Editorial: Clarify invariant that ISO Date Records are always valid](https://github.com/tc39/proposal-temporal/commit/69a9962a9f2dcb45e964238646898ea4e2376d93)~~ - N/A - [x] [Editorial: Remove unnecessary month code check](https://github.com/tc39/proposal-temporal/commit/91108541839a1bb6bfcef4522d8d5bb4208e612b) - https://codeberg.org/kiesel-js/kiesel/commit/949579585682d9e821a1b45476583f41fd3ce336 - [x] ~~[Editorial: ParseMonthCode of a month code is infallible](https://github.com/tc39/proposal-temporal/commit/c1f7bd564466ebbdcfc16efbdb9d3d8d9dc379d6)~~ - N/A - [x] [Normative: Change NudgeToCalendarUnit to use relative date when comparing durations](https://github.com/tc39/proposal-temporal/commit/17e12be0af42a02b3389d22417923f29f93c16c5) - https://codeberg.org/kiesel-js/kiesel/commit/edc8e71ce6fdf8237311829dd5d1972275f9db37 - [x] [Editorial: In GetDifferenceSettings, move NegateRoundingMode call](https://github.com/tc39/proposal-temporal/commit/c11021a451c95e4ab6d3b7c1ca9bd524fbb0c96d) - https://codeberg.org/kiesel-js/kiesel/commit/937e137c8a34b99c8fb83cc52c415699d72c1fad - [x] ~~[Editorial: Check total nanoseconds in IsValidDuration](https://github.com/tc39/proposal-temporal/commit/68004cc37adece862d4939ac358a8d89a5105b6b)~~ - N/A - [x] [Editorial: Replace BalanceISODate with AddDaysToISODate](https://github.com/tc39/proposal-temporal/commit/b28ef0864bf47be305e09a25b706af7a3c930a0d) - https://codeberg.org/kiesel-js/kiesel/commit/937e137c8a34b99c8fb83cc52c415699d72c1fad - [x] ~~[Editorial: Switch +1/-1 to avoid negating sign](https://github.com/tc39/proposal-temporal/commit/407fa01da611627be4cf5467df7bc32a1ae113fb)~~ - N/A - [x] ~~[Editorial: Change check to assertion in IsValidDuration](https://github.com/tc39/proposal-temporal/commit/e65f411f1cfceb3a54c30139a3d734f7efa7f04b)~~ - N/A - [x] ~~[Editorial: Add early return in CalendarDateUntil](https://github.com/tc39/proposal-temporal/commit/264e4b8fae582faf2f3f558f1d72ae29cae5607f)~~ - N/A - [x] ~~[Editorial: Add explanatory note to CalendarMonthDayFromFields](https://github.com/tc39/proposal-temporal/commit/163d589a4ddf4e9e152c1fa53a10cb8197077c75)~~ - N/A - [x] ~~[Editorial: Use GetOptionsObject from ECMA-262](https://github.com/tc39/proposal-temporal/commit/e4c2edd62d7c4f821a0b08a4245a2cef3a962e01)~~ - N/A - [x] ~~[Editorial: Refactor ISODateSurpasses parallel to NonISODateSurpasses](https://github.com/tc39/proposal-temporal/commit/196a31919d2997b66a3c4171f94baf9fc3f5dd4a)~~ - N/A - [ ] [Revert "Editorial: Move AnnotatedTime early error to a separate parse step"](https://github.com/tc39/proposal-temporal/commit/3ffa6778ebc01e891c50389d1c3143815c42e7e3) - [x] [Normative: Disallow adding weeks, days, and time units to PlainYearMonth](https://github.com/tc39/proposal-temporal/commit/41faca474a415a0f0d3f00167f0ebf36ceb432e6) - https://codeberg.org/kiesel-js/kiesel/commit/edc8e71ce6fdf8237311829dd5d1972275f9db37 - [x] ~~[Normative: Format plain Temporal objects without regard to DST](https://github.com/tc39/proposal-temporal/commit/377fb80e6390f3bdaaf83842a400314662b0d39c)~~ - N/A (Intl) - [x] ~~[Editorial: fix repeated 'the' in a couple of AO headers](https://github.com/tc39/proposal-temporal/commit/e3d6bfb6c03362fc88b3ed00aeaddcca64d666a7)~~ - N/A - [ ] [Editorial: Fix typo](https://github.com/tc39/proposal-temporal/commit/56828a263993f6654c177239c966deb5f15247ec) - [x] ~~[Editorial: Remove language about ISO reference years > 2035](https://github.com/tc39/proposal-temporal/commit/6cc7026667c61ddfb804dcb81eea6d160dc8cf1a)~~ - N/A - [x] ~~[Editorial: Clarify reference about out-of-range ISO reference year](https://github.com/tc39/proposal-temporal/commit/f74e1891037532c257b7e8cf8b2b290813ebf7f3)~~ - N/A - [ ] [Editorial: Replace "otherwise" with "else"](https://github.com/tc39/proposal-temporal/commit/1ae3e42158bb5c24fbe0f6db197b8a161f38c430) - [x] ~~[Editorial: Remove else clauses after early returns](https://github.com/tc39/proposal-temporal/commit/e6e031f8c8170ca47288aee65177546b3cefc94e)~~ - N/A - [x] ~~[Editorial: Fix argument type in CompareSurpasses](https://github.com/tc39/proposal-temporal/commit/5ae199537c25c4cde0d163606a4fc6945906f4ad)~~ - N/A - [x] ~~[Editorial: Adjust description of CalendarResolveFields](https://github.com/tc39/proposal-temporal/commit/9c028e5aca50c6c0b85fcf0f287dec17b2251d98)~~ - N/A - [x] ~~[Editorial: Refactor CalendarResolveFields parallel to NonISOResolveFields](https://github.com/tc39/proposal-temporal/commit/b2e8299c7cb3b9a81e5d59d2a91d5612800002c3)~~ - N/A - [x] ~~[Editorial: Remove an unreachable path in TimeZoneEquals AO](https://github.com/tc39/proposal-temporal/commit/a3cb4bbb30d8a71fbe6cd4e88f1be77b410f6968)~~ - N/A - [x] ~~[Editorial: Work around inconsistency in CLDR data sources](https://github.com/tc39/proposal-temporal/commit/94a7487e26c10032b222e35ae46f89630f8995fe)~~ - N/A (Intl) - [ ] [Editorial: Follow editorial conventions (multiple commits)](https://github.com/tc39/proposal-temporal/pull/3274) - [x] ~~[Editorial: Account for [[pattern]] etc. in AdjustDateTimeStyleFormat](https://github.com/tc39/proposal-temporal/commit/64a2395e1978c371763ab512fc42e5cc8a5ffc64)~~ - N/A (Intl) - [x] ~~[Editorial: Add descriptions to abstract operations missing them](https://github.com/tc39/proposal-temporal/commit/86a7b4676cca3c8f87341c048dab914a1db71def)~~ - N/A
linus commented 2025-09-06 16:22:55 +02:00
Author
Owner
Copy link

All done :^)

Current test262 status:

$ grep Temporal tools/test262/results.json | grep PASS | wc -l       
4428
$ grep Temporal tools/test262/results.json | grep FAIL | wc -l
175
All done :^) Current test262 status: ```console $ grep Temporal tools/test262/results.json | grep PASS | wc -l 4428 $ grep Temporal tools/test262/results.json | grep FAIL | wc -l 175 ```
linus commented 2025-10-04 01:44:13 +02:00
Author
Owner
Copy link

Progress:

$ grep Temporal tools/test262/results.json | grep PASS | wc -l
4542
$ grep Temporal tools/test262/results.json | grep FAIL | wc -l
117

The only failing tests not related to Temporal/Intl integration are test/built-ins/Temporal/Duration/prototype/total/precision-exact-mathematical-values-{6,7}.js which also fail for Boa and V8, so definitely a temporal_rs issue.

Progress: ```console $ grep Temporal tools/test262/results.json | grep PASS | wc -l 4542 $ grep Temporal tools/test262/results.json | grep FAIL | wc -l 117 ``` The only failing tests not related to Temporal/Intl integration are `test/built-ins/Temporal/Duration/prototype/total/precision-exact-mathematical-values-{6,7}.js` which also fail for Boa and V8, so definitely a temporal_rs issue.
🚀 1
linus commented 2025-10-28 01:55:10 +01:00
Author
Owner
Copy link

More progress (only temporal_rs/test262 updates):

$ grep Temporal tools/test262/results.json | grep PASS | wc -l
4557
$ grep Temporal tools/test262/results.json | grep FAIL | wc -l
102
More progress (only temporal_rs/test262 updates): ```console $ grep Temporal tools/test262/results.json | grep PASS | wc -l 4557 $ grep Temporal tools/test262/results.json | grep FAIL | wc -l 102 ```
linus closed this issue 2026-03-24 18:35:48 +01:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
zig-dev
unicode-versions
0.3.0
0.2.0
Labels
Clear labels   
blocked
Blocked by another issue, here or upstream

  
bug
Something is not working

  
build
Issue related to the build system

  
ci
Issue related to CI

  
cli
Issue related to the CLI

  
conformance
Missing or partially implemented feature required for ECMA-262 conformance

  
crash
Bug causing a native crash

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or improvement unrelated to conformance

  
good first issue
Interested in contributing? Get started here.

  
interpreter
Issue related to the interpreter pipeline (IR, bytecode, VM)

  
invalid
Not an actionable issue and not worth talking about

  
parser
Issue related to the parser pipeline (tokenizer, parser, AST)

  
performance
Something is slow (and we want to make it faster!)

  
portability
Issue related to running on a certain target

  
proposal
Issue related to implementing an ECMA-262 proposal

  
question
Not an actionable issue but worth talking about

  
regression
This used to work but no longer does

  
runtime
Issue related to the runtime (execution, types, builtins)

  
tech debt
Tech debt :)

  
testing
Issue related to testing

  
upstream
Related to an upstream project

No labels
blocked
bug
build
ci
cli
conformance
crash
duplicate
enhancement
good first issue
interpreter
invalid
parser
performance
portability
proposal
question
regression
runtime
tech debt
testing
upstream
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
kiesel-js/kiesel#124
No description provided.