| commit | 6489fe94c6edc435f5f0b291032c0e8883212afd | [log] [tgz] |
|---|---|---|
| author | pcc <[email protected]> | Wed Jun 28 21:30:44 2017 |
| committer | Commit Bot <[email protected]> | Wed Jun 28 21:30:44 2017 |
| tree | 99fb77af6d9f318cd7b5d6b06ba7fad6d2dfea63 | |
| parent | 06129aec96668a5747023b173b8beab1e0651036 [diff] |
Stop building the gold plugin and linking lld against tcmalloc. As far as I am aware, there are no remaining users of the gold plugin (v8, the last user I am aware of, stopped downloading it as part of its build in https://chromium-review.googlesource.com/547058 and removed build support in https://chromium-review.googlesource.com/549300), so we no longer need to build it. Also, now that we have started using ThinLTO in official builds, not only is the perf gain of linking lld against tcmalloc not as important, but I have also measured it to be smaller in relative terms. For base_unittests: With tcmalloc (median of 6): 42.29s With glibc malloc: 44.61s So about 5%, which is about half of what I measured for regular LTO. And of course the absolute delta is smaller as well. I think that justifies removing it. We can re-evaluate for the toolchain as a whole at a later time. BUG=607968 [email protected],[email protected] Review-Url: https://codereview.chromium.org/2963693002 Cr-Commit-Position: refs/heads/master@{#483149}