Details

Reviewers

Group Reviewers

webidl
Restricted Project

Commits

rFIREFOXAUTOLANDddddc40e0fd5: Bug 1919718 - Part 1: Implement HTMLInputElement.colorSpace r=emilio,webidl…
rFIREFOXAUTOLAND609b28f0524d: Bug 1919718 - Part 1: Implement HTMLInputElement.colorSpace r=emilio,webidl…

Bugzilla Bug ID

1919718

Summary

Skipping the picker part for now, as we don't support wide color gamut yet. Color mapping doesn't work either because of how the picker element is implemented - it's using white-and-black-to-transparent linear-gradient on top of the solid color.

Diff Detail

Repository

rFIREFOXAUTOLAND firefox-autoland

Build Status

Buildable 899039
Build 1000135: arc lint + arc unit

Event Timeline

saschanaz planned changes to this revision.Jan 5 2026, 6:32 PM

saschanaz created this revision.

Herald added a project: secure-revision. · View Herald TranscriptJan 5 2026, 6:32 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Jan 5 2026, 6:32 PM

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Harbormaster completed remote builds in B893536: Diff 1179779.Jan 5 2026, 6:56 PM

saschanaz added inline comments.Jan 5 2026, 6:58 PM

dom/html/HTMLInputElement.cpp
5146	note: the fallback should keep the colorspace, otherwise it always serializes to `#000000`.

saschanaz planned changes to this revision.Jan 6 2026, 5:46 PM

saschanaz updated this revision to Diff 1180277.

Harbormaster completed remote builds in B893925: Diff 1180277.Jan 6 2026, 6:11 PM

saschanaz planned changes to this revision.Jan 7 2026, 4:42 PM

saschanaz updated this revision to Diff 1180884.

Harbormaster completed remote builds in B894421: Diff 1180884.Jan 7 2026, 5:20 PM

saschanaz planned changes to this revision.Thu, Jan 8, 10:38 AM

saschanaz updated this revision to Diff 1181365.

Harbormaster completed remote builds in B894801: Diff 1181365.Thu, Jan 8, 10:58 AM

saschanaz planned changes to this revision.Thu, Jan 8, 3:27 PM

saschanaz updated this revision to Diff 1181499.

saschanaz added a child revision: D278296: Bug 1919718 - Part 2: Implement HTMLInputElement.alpha r=emilio.

Harbormaster completed remote builds in B894898: Diff 1181499.Thu, Jan 8, 3:45 PM

saschanaz planned changes to this revision.Fri, Jan 9, 6:06 PM

saschanaz updated this revision to Diff 1182360.

saschanaz retitled this revision from WIP: Bug 1919718 - Part 1: Add HTMLInputElement.colorSpace to WIP: Bug 1919718 - Part 1: Implement HTMLInputElement.colorSpace.

saschanaz requested review of this revision.Fri, Jan 9, 6:18 PM

saschanaz updated this revision to Diff 1182370.

saschanaz retitled this revision from WIP: Bug 1919718 - Part 1: Implement HTMLInputElement.colorSpace to Bug 1919718 - Part 1: Implement HTMLInputElement.colorSpace r=emilio.

saschanaz edited the summary of this revision. (Show Details)

saschanaz added a reviewer: emilio.

Herald added a reviewer: webidl. · View Herald TranscriptFri, Jan 9, 6:18 PM

Herald added a reviewer: Restricted Project. · View Herald Transcript

Herald added a subscriber: zrhoffman. · View Herald Transcript

Harbormaster completed remote builds in B895642: Diff 1182360.Fri, Jan 9, 6:22 PM

Please send intents as appropriate if this is not intended to be behind a pref. Otherwise add the pref :)

dom/html/HTMLInputElement.cpp
799	`CopyUTF8toUTF16` saves one temporary.
5146	Can you file a spec issue here or something?
dom/webidl/HTMLInputElement.webidl
41	Do you want to pref this?

This revision is now accepted and ready to land.Fri, Jan 9, 6:25 PM

Harbormaster completed remote builds in B895651: Diff 1182370.Fri, Jan 9, 6:36 PM

saschanaz added inline comments.Sat, Jan 10, 12:06 PM

dom/html/HTMLInputElement.cpp
5146	What spec issue? The `#000000` thing? That was purely the patch logic issue.

emilio added inline comments.Sat, Jan 10, 12:18 PM

dom/html/HTMLInputElement.cpp
5146	What spec issue? The `#000000` thing? That was purely the patch logic issue. Ah,I was misreading the spec quote as unconditionally requesting html compatible serialization even for alpha / color-space enums.