Page MenuHomePhabricator
Differential D246313

Bug 1950511 - Fix .rpm file_path on x86 r?#releng
ClosedPublic
Actions

Authored by • gabriel on Apr 22 2025, 6:48 PM.
Tags
Referenced Files
Unknown Object (File)
Nov 6 2025, 9:08 PM
Unknown Object (File)
Oct 15 2025, 2:06 PM
Unknown Object (File)
Oct 14 2025, 8:10 PM
Unknown Object (File)
Oct 14 2025, 6:36 AM
Unknown Object (File)
Oct 7 2025, 5:48 AM
Unknown Object (File)
Sep 20 2025, 10:34 PM
Unknown Object (File)
Jun 22 2025, 12:59 PM
Unknown Object (File)
Jun 22 2025, 11:14 AM
View All 13 Files
Subscribers
jlorenzo
reviewbot

Details

Reviewers
jlorenzo
Commits
rMOZILLACENTRALd0042028b71c: Bug 1950511 - Fix .rpm file_path on x86 r=jlorenzo
Bugzilla Bug ID
1950511

Diff Detail

Event Timeline

• gabriel created this revision.Apr 22 2025, 6:48 PM
Herald added a project: secure-revision. · View Herald TranscriptApr 22 2025, 6:48 PM
phab-bot published this revision for review.Apr 22 2025, 6:48 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
• gabriel added a child revision: D246314: Bug 1950511 - Copy built rpms into artifact directories r?#releng.Apr 22 2025, 6:48 PM
Harbormaster failed remote builds in B781102: Diff 1019281!Apr 22 2025, 6:49 PM
jlorenzo accepted this revision.Apr 24 2025, 3:08 PM
jlorenzo added a project: testing-exception-unchanged (Doesn't change behavior for users).
jlorenzo added a subscriber: jlorenzo.

LGTM. Same comment as https://phabricator.services.mozilla.com/D246312#8531394

This revision is now accepted and ready to land.Apr 24 2025, 3:08 PM
• gabriel updated this revision to Diff 1020661.Apr 24 2025, 6:00 PM
• gabriel updated this revision to Diff 1020676.Apr 24 2025, 6:05 PM
• gabriel removed a reviewer: releng-reviewers.Apr 24 2025, 6:28 PM
Harbormaster failed remote builds in B782149: Diff 1020661!Apr 24 2025, 6:51 PM
reviewbot added a subscriber: reviewbot.Apr 24 2025, 6:53 PM

Code analysis found 4 defects in diff 1020676:

  • 1 defect found by license (Mozlint)
  • 1 defect found by py-black (Mozlint)
  • 1 defect found by py-ruff (Mozlint)
  • 1 defect found by source-test-vendor-rust
IMPORTANT: Found 4 defects (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing
NOTE: Tasks were added or removed in diff 1020676.

The following parameter sets have differences:

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 1020676.

Harbormaster failed remote builds in B782164: Diff 1020676!Apr 24 2025, 6:53 PM
• gabriel updated this revision to Diff 1020713.Apr 24 2025, 7:09 PM
reviewbot added a comment.Apr 24 2025, 7:54 PM
NOTE: Tasks were added or removed in diff 1020713.

The following parameter sets have differences:

If you see a problem in this automated review, please report it here.

Harbormaster completed remote builds in B782187: Diff 1020713.Apr 24 2025, 7:54 PM
Closed by commit rMOZILLACENTRALd0042028b71c: Bug 1950511 - Fix .rpm file_path on x86 r=jlorenzo (authored by • gabriel). · Explain WhyApr 28 2025, 8:24 PM
This revision was automatically updated to reflect the committed changes.
• gabriel added a commit: rMOZILLACENTRALd0042028b71c: Bug 1950511 - Fix .rpm file_path on x86 r=jlorenzo.

Revision Contents
Changeset List

PathSize
python/
mozbuild/
mozbuild/
repackaging/
5 lines

Diff 1022079

View Options

python/mozbuild/mozbuild/repackaging/rpm.py

Loading...
Privacy · Cookies · Legal