I think what we should do here is modify repackaging.desktop_file here: https://searchfox.org/mozilla-central/source/python/mozbuild/mozbuild/repackaging/desktop_file.py#174

We can try PKG_NAME and fall-back to the DEB_PKG_NAME.

pkg_name = build_variables.get("DEB_PKG_NAME", build_variables.get("PKG_NAME"))
if not pkg_name:
    raise ValueError("Package name is missing. Ensure that 'PKG_NAME' is set in build variables.")

We could also update the callers to pass in "PKG_NAME". I think the only other thing using these repackaging.desktop file module is the Firefox Flatpak. But this is a quick way to stop perpetuating "DEB_PKG_NAME"

probably specific to .debs

Never-mind updating the callers...

It's in a few places: https://searchfox.org/mozilla-central/search?q=DEB_PKG_NAME&path=&case=true&regexp=false

Using a pkg_name variable in repackaging.desktop_file instead of looking up the hard-coded "DEB_PKG_NAME" would be an improvement.

I’ve start to work on using the common module with the deb repackaging system and I’ve spot this problem too. The DEB_ prefix will be removed from the files on the repackaging module.