Details

Reviewers

• gabriel

Commits

rMOZILLACENTRALb7fd45513dbf: Bug 1950511 - part 1: prepare the repackaging files related to rpm r=gabriel

Bugzilla Bug ID

1950511

Diff Detail

Repository: rMOZILLACENTRAL mozilla-central

Event Timeline

alubert created this revision.Jan 29 2025, 2:03 PM

Herald added a project: secure-revision. · View Herald TranscriptJan 29 2025, 2:03 PM

Harbormaster completed remote builds in B748870: Diff 976159.Jan 29 2025, 2:03 PM

phab-bot published this revision for review.Jan 29 2025, 2:03 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a subscriber: Standard8. · View Herald TranscriptJan 29 2025, 2:03 PM

alubert added a child revision: D235975: Bug 1950511 - part 2: add a common module to use with both deb and rpm r=gabriel.Jan 29 2025, 2:03 PM

jcristau added a subscriber: jcristau.Jan 29 2025, 2:15 PM

jcristau added inline comments.

browser/installer/linux/app/rpm/manpages.in
1 ↗	(On Diff #976159)	This looks odd. Is this file actually used?

sylvestre added subscribers: gerard-majax, sylvestre.Jan 29 2025, 2:39 PM

sylvestre added inline comments.

browser/installer/linux/app/rpm/package-prefs.js
7	@gerard-majax isn't it the default value now on Linux?

jcristau added inline comments.Jan 29 2025, 2:42 PM

browser/installer/linux/app/rpm/package-prefs.js
7	only in nightly afaict: https://searchfox.org/mozilla-central/rev/a965e3c683ecc035dee1de72bd33a8d91b1203ed/modules/libpref/init/StaticPrefList.yaml#3103

gerard-majax added inline comments.Jan 29 2025, 2:54 PM

browser/installer/linux/app/rpm/package-prefs.js
7	yes only nightly for now

alubert added inline comments.Jan 30 2025, 8:52 AM

browser/installer/linux/app/rpm/manpages.in
1 ↗	(On Diff #976159)	This file come from the `browser/installer/linux/app/deb` directory and its only mandatory with the debian building process. We can remove this file, the `mv_manpage_files` function from the patch part-2 needs to be modify to not copy this file if missing.

alubert updated this revision to Diff 976728.Jan 30 2025, 8:56 AM

Harbormaster completed remote builds in B749286: Diff 976728.Jan 30 2025, 8:56 AM

• gabriel requested changes to this revision.Feb 5 2025, 10:29 PM

• gabriel added inline comments.

browser/installer/linux/app/rpm/manpages.in
1 ↗	(On Diff #976159)	I think we should remove this and modify the function if it is un-used.
browser/installer/linux/app/rpm/package-prefs.js
7	LGTM we do the same thing on .deb (for now.)

This revision now requires changes to proceed.Feb 5 2025, 10:29 PM

alubert requested review of this revision.Feb 10 2025, 9:37 AM

alubert updated this revision to Diff 981926.

Harbormaster completed remote builds in B753104: Diff 981926.Feb 10 2025, 9:37 AM

• gabriel added inline comments.Feb 11 2025, 10:17 PM

browser/installer/linux/app/rpm/manpages.in
1 ↗	(On Diff #976159)	Instead of modifying mv_manpage_files let's not call it here: https://phabricator.services.mozilla.com/D235976#8216799 If it is specific to .deb let's leave it out of the common module.

jcristau requested changes to this revision.Feb 24 2025, 4:20 PM

jcristau added inline comments.

browser/installer/linux/app/rpm/firefox.spec.in
5	Should this be a variable, so nightly/beta/etc get different summaries?
python/sites/repackage-rpm.txt
1–2 ↗	(On Diff #981926)	This belongs with part 3. That said I'm not sure we have a separate site for this, it could presumably reuse repackage-deb or repackage-desktop-file which are identical?

This revision now requires changes to proceed.Feb 24 2025, 4:20 PM

alubert added inline comments.Feb 25 2025, 8:23 AM

browser/installer/linux/app/rpm/firefox.spec.in
5	You right! There is the variable `DESCRIPTION` available for this summary. I’ve must have forget to update this file.
python/sites/repackage-rpm.txt
1–2 ↗	(On Diff #981926)	For what I’ve understand, this file is automatically detected during the process by using the value of the virtual environment related to the command. So can it mean that, to reuse one of these other files, the virtual env must be shared? And you right, this file belong to the part 3, I will move it in this patch.

alubert requested review of this revision.Feb 25 2025, 8:29 AM

alubert updated this revision to Diff 990094.

Harbormaster completed remote builds in B759177: Diff 990094.Feb 25 2025, 8:30 AM

Please update the commit message to use this bug #: https://bugzilla.mozilla.org/show_bug.cgi?id=1950505

This revision now requires changes to proceed.Feb 26 2025, 12:02 AM

alubert requested review of this revision.Feb 26 2025, 10:15 AM

alubert updated this revision to Diff 990862.

alubert retitled this revision from Bug 213920 - part 1: prepare the repackaging files related to rpm r=gabriel to Bug 1950511 - part 1: prepare the repackaging files related to rpm r=gabriel.

alubert changed the Bugzilla Bug ID from 213920 to 1950511.

Harbormaster completed remote builds in B759779: Diff 990862.Feb 26 2025, 10:15 AM

• gabriel accepted this revision.Mar 3 2025, 4:28 PM

alubert updated this revision to Diff 1012321.Apr 8 2025, 8:11 AM

Harbormaster completed remote builds in B775905: Diff 1012321.Apr 8 2025, 8:28 AM

Does this look good to you @jcristau?

alubert updated this revision to Diff 1015971.Apr 15 2025, 7:24 AM

Harbormaster completed remote builds in B778595: Diff 1015971.Apr 15 2025, 7:43 AM

jlorenzo removed a reviewer: jcristau.Apr 24 2025, 3:04 PM

This revision is now accepted and ready to land.Apr 24 2025, 3:04 PM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!