Attachment 8413194 Details for Bug 885798

[patch] Add Number.{MAX,MIN}_SAFE_INTEGER

number.patch (text/plain), 3.22 KB, created by Stephen Kelly

(hide)

Description:

Filename:

MIME Type:

Creator: Stephen Kelly

Size: 3.22 KB

patch

obsolete

># HG changeset patch
># User Stephen Kelly <steveire@gmail.com>
># Date 1398522950 -7200
>#      Sat Apr 26 16:35:50 2014 +0200
># Node ID a7470405a49b1020f6028d731ff1903ab2c83aa6
># Parent  5010b38abf18590cb17cf35e0cfaa933579cd748
>Bug 885798 - Add Number.{MAX,MIN}_SAFE_INTEGER. r=evilpie
>
>diff --git a/js/src/jsnum.cpp b/js/src/jsnum.cpp
>--- a/js/src/jsnum.cpp
>+++ b/js/src/jsnum.cpp
>@@ -1090,16 +1090,20 @@ enum nc_slot {
>  * using union jsdpun.
>  */
> static JSConstDoubleSpec number_constants[] = {
>     {0,                         "NaN",               0,{0,0,0}},
>     {0,                         "POSITIVE_INFINITY", 0,{0,0,0}},
>     {0,                         "NEGATIVE_INFINITY", 0,{0,0,0}},
>     {1.7976931348623157E+308,   "MAX_VALUE",         0,{0,0,0}},
>     {0,                         "MIN_VALUE",         0,{0,0,0}},
>+    /* ES6 (April 2014 draft) 20.1.2.6 */
>+    {9007199254740991,          "MAX_SAFE_INTEGER",  0,{0,0,0}},
>+    /* ES6 (April 2014 draft) 20.1.2.10 */
>+    {-9007199254740991,         "MIN_SAFE_INTEGER",  0,{0,0,0}},
>     /* ES6 (May 2013 draft) 15.7.3.7 */
>     {2.2204460492503130808472633361816e-16, "EPSILON", 0,{0,0,0}},
>     {0,0,0,{0,0,0}}
> };
> 
> #if (defined __GNUC__ && defined __i386__) || \
>     (defined __SUNPRO_CC && defined __i386)
> 
>diff --git a/js/src/tests/ecma_6/Number/20.1.2.10-MIN_SAFE_INTEGER.js b/js/src/tests/ecma_6/Number/20.1.2.10-MIN_SAFE_INTEGER.js
>new file mode 100644
>--- /dev/null
>+++ b/js/src/tests/ecma_6/Number/20.1.2.10-MIN_SAFE_INTEGER.js
>@@ -0,0 +1,26 @@
>+// Any copyright is dedicated to the Public Domain.
>+// http://creativecommons.org/licenses/publicdomain/
>+
>+//-----------------------------------------------------------------------------
>+
>+var BUGNUMBER = 885798;
>+var summary = "ES6 (draft April 2014) 20.1.2.10 Number.MIN_SAFE_INTEGER";
>+
>+print(BUGNUMBER + ": " + summary);
>+
>+/**************
>+ * BEGIN TEST *
>+ **************/
>+
>+// Test value
>+assertEq(Number.MIN_SAFE_INTEGER, -(Math.pow(2, 53) - 1));
>+
>+//Test property attributes
>+var descriptor = Object.getOwnPropertyDescriptor(Number, 'MIN_SAFE_INTEGER');
>+
>+assertEq(descriptor.writable, false);
>+assertEq(descriptor.configurable, false);
>+assertEq(descriptor.enumerable, false);
>+
>+if (typeof reportCompare === "function")
>+  reportCompare(true, true);
>diff --git a/js/src/tests/ecma_6/Number/20.1.2.6-MAX_SAFE_INTEGER.js b/js/src/tests/ecma_6/Number/20.1.2.6-MAX_SAFE_INTEGER.js
>new file mode 100644
>--- /dev/null
>+++ b/js/src/tests/ecma_6/Number/20.1.2.6-MAX_SAFE_INTEGER.js
>@@ -0,0 +1,26 @@
>+// Any copyright is dedicated to the Public Domain.
>+// http://creativecommons.org/licenses/publicdomain/
>+
>+//-----------------------------------------------------------------------------
>+
>+var BUGNUMBER = 885798;
>+var summary = "ES6 (draft April 2014) 20.1.2.6 Number.MAX_SAFE_INTEGER";
>+
>+print(BUGNUMBER + ": " + summary);
>+
>+/**************
>+ * BEGIN TEST *
>+ **************/
>+
>+// Test value
>+assertEq(Number.MAX_SAFE_INTEGER, Math.pow(2, 53) - 1);
>+
>+//Test property attributes
>+var descriptor = Object.getOwnPropertyDescriptor(Number, 'MAX_SAFE_INTEGER');
>+
>+assertEq(descriptor.writable, false);
>+assertEq(descriptor.configurable, false);
>+assertEq(descriptor.enumerable, false);
>+
>+if (typeof reportCompare === "function")
>+  reportCompare(true, true);

Flags:

evilpies: review+

Actions: View | Diff | Review

Attachments on bug 885798: 771708 | 771762 | 773980 | 8413194 | 8413221