Attachment 773980 Details for Bug 885798

[patch] Add ES6 Number constants EPSILON and MAX_INTEGER.

numconsts.patch (text/plain), 3.52 KB, created by Till Schneidereit [:till]

(hide)

Description:

Filename:

MIME Type:

Creator: Till Schneidereit [:till]

Size: 3.52 KB

patch

obsolete

># HG changeset patch
># User Till Schneidereit <till@tillschneidereit.net>
># Date 1373547070 -7200
>#      Thu Jul 11 14:51:10 2013 +0200
># Node ID 08e8ad3553b104acae2f16a4b8f10eca1c97a3e2
># Parent  f09e9aafa2d0f3bfea1bf9fc35532be2997426eb
>Bug 885798 - Add ES6 Number constants EPSILON and MAX_INTEGER. r=jwalden
>
>diff --git a/js/src/jsnum.cpp b/js/src/jsnum.cpp
>--- a/js/src/jsnum.cpp
>+++ b/js/src/jsnum.cpp
>@@ -1004,30 +1004,36 @@ static const JSFunctionSpec number_stati
> 
> /* NB: Keep this in synch with number_constants[]. */
> enum nc_slot {
>     NC_NaN,
>     NC_POSITIVE_INFINITY,
>     NC_NEGATIVE_INFINITY,
>     NC_MAX_VALUE,
>     NC_MIN_VALUE,
>+    NC_EPSILON,
>+    NC_MAX_INTEGER,
>     NC_LIMIT
> };
> 
> /*
>  * Some to most C compilers forbid spelling these at compile time, or barf
>  * if you try, so all but MAX_VALUE are set up by InitRuntimeNumberState
>  * using union jsdpun.
>  */
> static JSConstDoubleSpec number_constants[] = {
>     {0,                         "NaN",               0,{0,0,0}},
>     {0,                         "POSITIVE_INFINITY", 0,{0,0,0}},
>     {0,                         "NEGATIVE_INFINITY", 0,{0,0,0}},
>     {1.7976931348623157E+308,   "MAX_VALUE",         0,{0,0,0}},
>     {0,                         "MIN_VALUE",         0,{0,0,0}},
>+    /* ES6 (May 2013 draft) 15.7.3.7 */
>+    {2.2204460492503130808472633361816e-16, "EPSILON", 0,{0,0,0}},
>+    /* ES6 (May 2013 draft) 15.7.3.8 */
>+    {(1ULL << 53) - 1,          "MAX_INTEGER",       0,{0,0,0}},
>     {0,0,0,{0,0,0}}
> };
> 
> double js_NaN;
> double js_PositiveInfinity;
> double js_NegativeInfinity;
> 
> #if (defined __GNUC__ && defined __i386__) || \
>diff --git a/js/src/tests/ecma_6/Number/15.7.3.7-EPSILON.js b/js/src/tests/ecma_6/Number/15.7.3.7-EPSILON.js
>new file mode 100644
>--- /dev/null
>+++ b/js/src/tests/ecma_6/Number/15.7.3.7-EPSILON.js
>@@ -0,0 +1,24 @@
>+// Any copyright is dedicated to the Public Domain.
>+// http://creativecommons.org/licenses/publicdomain/
>+
>+//-----------------------------------------------------------------------------
>+var BUGNUMBER = 885798;
>+var summary = "ES6 (draft May 2013) 15.7.3.7 Number.EPSILON";
>+
>+print(BUGNUMBER + ": " + summary);
>+
>+/**************
>+ * BEGIN TEST *
>+ **************/
>+
>+// Test value
>+assertEq(Number.EPSILON, Math.pow(2, -52));
>+
>+// Test property attributes
>+var descriptor = Object.getOwnPropertyDescriptor(Number, 'EPSILON');
>+assertEq(descriptor.writable, false);
>+assertEq(descriptor.configurable, false);
>+assertEq(descriptor.enumerable, false);
>+
>+if (typeof reportCompare === "function")
>+  reportCompare(true, true);
>\ No newline at end of file
>diff --git a/js/src/tests/ecma_6/Number/15.7.3.8-MAX_INTEGER.js b/js/src/tests/ecma_6/Number/15.7.3.8-MAX_INTEGER.js
>new file mode 100644
>--- /dev/null
>+++ b/js/src/tests/ecma_6/Number/15.7.3.8-MAX_INTEGER.js
>@@ -0,0 +1,24 @@
>+// Any copyright is dedicated to the Public Domain.
>+// http://creativecommons.org/licenses/publicdomain/
>+
>+//-----------------------------------------------------------------------------
>+var BUGNUMBER = 885798;
>+var summary = "ES6 (draft May 2013) 15.7.3.7 Number.MAX_INTEGER";
>+
>+print(BUGNUMBER + ": " + summary);
>+
>+/**************
>+ * BEGIN TEST *
>+ **************/
>+
>+// Test value
>+assertEq(Number.MAX_INTEGER, Math.pow(2, 53) - 1);
>+
>+//Test property attributes
>+var descriptor = Object.getOwnPropertyDescriptor(Number, 'MAX_INTEGER');
>+assertEq(descriptor.writable, false);
>+assertEq(descriptor.configurable, false);
>+assertEq(descriptor.enumerable, false);
>+
>+if (typeof reportCompare === "function")
>+  reportCompare(true, true);
>\ No newline at end of file

Actions: View | Diff | Review

Attachments on bug 885798: 771708 | 771762 | 773980 | 8413194 | 8413221