Closed Bug 1866749 Opened 2 years ago Closed 1 month ago

Only send "log.entryAdded" events for console API calls that use the printer

Categories

(Remote Protocol :: WebDriver BiDi, task, P3)

task
Points:
2

Tracking

(firefox150 fixed)

RESOLVED FIXED
150 Branch
Tracking Status
firefox150 --- fixed

People

(Reporter: whimboo, Assigned: Sasha)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [webdriver:m19], [wptsync upstream][webdriver:relnote])

Attachments

(2 files)

As discussed on https://github.com/w3c/webdriver-bidi/issues/393 the log.entryAdded event should only be emitted for console API calls that actually use the printer. Otherwise they are omitted.

A test is added via the next wptsync bug 1866709.

I'll have a look and check which APIs are affected. We can have a black list of methods when we do not want to send a log.entryAdded event. We should check the following:

  • When time() is called twice it prints an error
  • groupEnd() doesn't print but with devtools ui we might want to have this
Flags: needinfo?(hskupin)
Priority: -- → P3
Whiteboard: [webdriver:backlog]

Given that this is a P3 bug lets investigate when we actually start working on it.

Flags: needinfo?(hskupin)
Whiteboard: [webdriver:backlog] → [webdriver:m19]
Priority: P3 → P2
Points: --- → 2
Priority: P2 → P3
Assignee: nobody → aborovova
Status: NEW → ASSIGNED

(In reply to Henrik Skupin [:whimboo][⌚️UTC+1] from comment #1)

I'll have a look and check which APIs are affected. We can have a black list of methods when we do not want to send a log.entryAdded event. We should check the following:

  • When time() is called twice it prints an error

Currently, time called twice doesn't send an event for an error because it looks like it's generated on the DevTools side. I'll take a look at it in the scope of bug 2005054.

  • groupEnd() doesn't print but with devtools ui we might want to have this

Per spec, groupEnd shouldn't send the event, but I agree it might be useful, so I've created the spec issue for it: https://github.com/w3c/webdriver-bidi/issues/1097.

Verify that "console.clear" doesn't trigger "log.entryAdded" event.

Whiteboard: [webdriver:m19] → [webdriver:m19], [wptsync upstream]
Upstream PR merged by moz-wptsync-bot
Whiteboard: [webdriver:m19], [wptsync upstream] → [webdriver:m19], [wptsync upstream][webdriver-relnote]
Whiteboard: [webdriver:m19], [wptsync upstream][webdriver-relnote] → [webdriver:m19], [wptsync upstream][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: