Only send "log.entryAdded" events for console API calls that use the printer
Categories
(Remote Protocol :: WebDriver BiDi, task, P3)
Tracking
(firefox150 fixed)
| Tracking | Status | |
|---|---|---|
| firefox150 | --- | fixed |
People
(Reporter: whimboo, Assigned: Sasha)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [webdriver:m19], [wptsync upstream][webdriver:relnote])
Attachments
(2 files)
As discussed on https://github.com/w3c/webdriver-bidi/issues/393 the log.entryAdded event should only be emitted for console API calls that actually use the printer. Otherwise they are omitted.
A test is added via the next wptsync bug 1866709.
| Reporter | ||
Comment 1•2 years ago
|
||
I'll have a look and check which APIs are affected. We can have a black list of methods when we do not want to send a log.entryAdded event. We should check the following:
- When
time()is called twice it prints an error groupEnd()doesn't print but with devtools ui we might want to have this
| Reporter | ||
Comment 2•2 years ago
|
||
Given that this is a P3 bug lets investigate when we actually start working on it.
| Reporter | ||
Updated•4 months ago
|
| Reporter | ||
Updated•4 months ago
|
| Reporter | ||
Updated•4 months ago
|
| Assignee | ||
Updated•1 month ago
|
| Assignee | ||
Comment 3•1 month ago
|
||
| Assignee | ||
Comment 4•1 month ago
|
||
(In reply to Henrik Skupin [:whimboo][⌚️UTC+1] from comment #1)
I'll have a look and check which APIs are affected. We can have a black list of methods when we do not want to send a
log.entryAddedevent. We should check the following:
- When
time()is called twice it prints an error
Currently, time called twice doesn't send an event for an error because it looks like it's generated on the DevTools side. I'll take a look at it in the scope of bug 2005054.
groupEnd()doesn't print but with devtools ui we might want to have this
Per spec, groupEnd shouldn't send the event, but I agree it might be useful, so I've created the spec issue for it: https://github.com/w3c/webdriver-bidi/issues/1097.
| Assignee | ||
Comment 5•1 month ago
|
||
Verify that "console.clear" doesn't trigger "log.entryAdded" event.
Comment 8•1 month ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e45e4d9f6900
https://hg.mozilla.org/mozilla-central/rev/311ebec6930f
| Assignee | ||
Updated•1 month ago
|
Updated•10 days ago
|
Updated•8 days ago
|
Description
•