Bug tracker

[vkucera]

Tracking bugs in the codebase found by analysis tools.

• GCC
• Clang-Tidy
• Cppcheck
• cpplint
• Include analyser
• O2 linter
• Unused files

[lubynets]

Dear All, tagging @vkucera, sorry for wide-posting in the main thread if it is not supposed for it,
Can it be the case that the clang-tidy misc-include-cleaner is over-sensitive and gives false positives? E.g. here the PWGHF/Core/HfMlResponseLcToPKPi.h is identified to have headers map, string and vector not used directly, while all these three types of objects are explicitly used in a header.
Or does the statement "included header ... is not used directly" mean something different?

[vkucera]

Dear All, tagging @vkucera, sorry for wide-posting in the main thread if it is not supposed for it, Can it be the case that the clang-tidy misc-include-cleaner is over-sensitive and gives false positives? E.g. here the PWGHF/Core/HfMlResponseLcToPKPi.h is identified to have headers map, string and vector not used directly, while all these three types of objects are explicitly used in a header. Or does the statement "included header ... is not used directly" mean something different?

Hi @vkucera , yes, those are false positives caused by the fact that Clang-Tidy is not able to compile that file. When Clang-Tidy throws clang-diagnostic-error, it cannot always properly analyse the file.

Tools/ML/model.h:25:10: error: 'onnxruntime_cxx_api.h' file not found [clang-diagnostic-error]